Render metadata property forms in the web UI - #1351
Draft
ikhoon wants to merge 1 commit into
Draft
Conversation
Motivation: The previous commit added declarable metadata property schemas to the server, but the web UI could not render input forms for them. Modifications: - Fetch the declared schemas via `GET /api/v1/metadataProperties` and render input fields for them in the project, repository and app identity creation popovers — text inputs with pattern validation, enum selects and checkboxes, using the schema `title`, `description` and `examples` as the label, help text and placeholder. - Fall back to a raw JSON textarea when a schema declares no top-level `properties` keyword. - Send the entered values as the `properties` of the creation requests, and show the stored values in the app identity secret modal. - Use a single inline validation path (`noValidate` + react-hook-form) in the creation forms so required and pattern errors render consistently. Result: - Together with the previous commit, closes #1346. - The creation dialogs prompt for the properties declared in `metadataProperties` and reject invalid values before submission. Nothing changes when the server declares nothing.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ikhoon
marked this pull request as draft
August 6, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
#1350 added declarable metadata property schemas to the server,
but the web UI could not render input forms for them.
Modifications:
GET /api/v1/metadataPropertiesand renderinput fields for them in the project, repository and app identity creation
popovers — text inputs with pattern validation, enum selects and checkboxes,
using the schema
title,descriptionandexamplesas the label, helptext and placeholder.
propertieskeyword.propertiesof the creation requests, andshow the stored values in the app identity secret modal.
noValidate+ react-hook-form) in thecreation forms so required and pattern errors render consistently.
Result:
metadataPropertiesand reject invalid values before submission. Nothingchanges when the server declares nothing.